[libc-commits] [PATCH] D120914: [libc] Initial support for darwin-aarch64.

Mon Mar 7 14:57:39 PST 2022

sivachandra added a comment.

Can I trouble with another request? Adding conditionals for errno and fp exception testing is setting a bad precedence. Can we instead add convenience macros `EXPECT_MATH_ERRNO` and `EXPECT_MATH_FPEXCEPT` and separate out those changes from this patch?

================
Comment at: libc/src/__support/common.h:22

-#ifdef LLVM_LIBC_PUBLIC_PACKAGING
+#if defined(LLVM_LIBC_PUBLIC_PACKAGING) && (!defined(__APPLE__))
 #define LLVM_LIBC_FUNCTION(type, name, arglist)                                \
----------------
Can you add a detailed comment here explaining why `__APPLE__` be excluded? Also talk about its implications.

================
Comment at: libc/test/src/stdlib/strtold_test.cpp:178
            (__uint128_t(0x7ffe800000) << 40),
-           (__uint128_t(0x7ffe000000000000) << 64));
+           (__uint128_t(0x7ffe000000000000) << 64), ERANGE);
   run_test("0x123456789abcdef", 17, 0x43723456789abcdf,
----------------
Why are the changes in this file required?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120914/new/

https://reviews.llvm.org/D120914