[libc-commits] [PATCH] D121091: [libc] Align the stack pointer in the start function.
Jeff Bailey via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Mar 7 09:33:56 PST 2022
jeffbailey accepted this revision.
jeffbailey added inline comments.
This revision is now accepted and ready to land.
================
Comment at: libc/test/loader/linux/CMakeLists.txt:60
+if(NOT (${LIBC_TARGET_ARCHITECTURE} STREQUAL "x86_64"))
+ return()
----------------
sivachandra wrote:
> jeffbailey wrote:
> > It might be nice to have this be a constexpr of tls_enabled or similar for arch bringup.
> Can you explain how you envision this constexpr to be used? Is it CMake variable or a variable in the source code?
Sorry - I was clearly not awake this morning and through this was in the C++ code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121091/new/
https://reviews.llvm.org/D121091
More information about the libc-commits
mailing list