[libc-commits] [PATCH] D128809: [libc][test] Remove dependency on sstream in algorithm_test.cpp

Clement Courbet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 29 06:40:19 PDT 2022


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/src/string/memory_utils/algorithm_test.cpp:11
+#include <type_traits>
+#include <vector>
 
----------------
Is this fine ?


================
Comment at: libc/test/src/string/memory_utils/algorithm_test.cpp:115
 
   const char *stripComments(const char *expected) {
     expected_.clear();
----------------
maybe `std::string` to avoid the zero-termination handling ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128809/new/

https://reviews.llvm.org/D128809



More information about the libc-commits mailing list