[libc-commits] [PATCH] D127517: [libc] add integer writing to printf

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/stdio/printf_core/write_int_converter.h:24
+  if(to_conv.conv_val_ptr == nullptr) 
+    return -3;
+  
----------------
How is this return value defined?  Aren't errors normally -1?  And do we have tests for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127517/new/

https://reviews.llvm.org/D127517