[libc-commits] [libc] 306f273 - [libc][NFC] Eliminate the internal header library target.

Siva Chandra Reddy via libc-commits libc-commits at lists.llvm.org
Thu Jun 23 13:48:23 PDT 2022


Author: Siva Chandra Reddy
Date: 2022-06-23T20:45:25Z
New Revision: 306f2731f482d32ccf557996ff122f7293cb30cb

URL: https://github.com/llvm/llvm-project/commit/306f2731f482d32ccf557996ff122f7293cb30cb
DIFF: https://github.com/llvm/llvm-project/commit/306f2731f482d32ccf557996ff122f7293cb30cb.diff

LOG: [libc][NFC] Eliminate the internal header library target.

The internal header library target with name suffix .__header_library
has been removed as it serves no purpose now.

Added: 
    

Modified: 
    libc/cmake/modules/LLVMLibCLibraryRules.cmake

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/LLVMLibCLibraryRules.cmake b/libc/cmake/modules/LLVMLibCLibraryRules.cmake
index a50bb8a47a17f..50ee8549a8d83 100644
--- a/libc/cmake/modules/LLVMLibCLibraryRules.cmake
+++ b/libc/cmake/modules/LLVMLibCLibraryRules.cmake
@@ -153,24 +153,16 @@ function(create_header_library fq_target_name)
       endforeach()
     endif()
   endif()
-  set(interface_target_name "${fq_target_name}.__header_library__")
 
-  add_library(${interface_target_name} INTERFACE)
-  target_sources(${interface_target_name} INTERFACE ${FULL_HDR_PATHS})
+  add_library(${fq_target_name} INTERFACE)
+  target_sources(${fq_target_name} INTERFACE ${FULL_HDR_PATHS})
   if(ADD_HEADER_DEPENDS)
-    add_dependencies(${interface_target_name} ${ADD_HEADER_DEPENDS})
+    add_dependencies(${fq_target_name} ${ADD_HEADER_DEPENDS})
   endif()
-  set_target_properties(
-    ${interface_target_name}
-    PROPERTIES
-      INTERFACE_FLAGS "${ADD_HEADER_FLAGS}"
-  )
-
-  add_custom_target(${fq_target_name})
-  add_dependencies(${fq_target_name} ${interface_target_name})
   set_target_properties(
     ${fq_target_name}
     PROPERTIES
+      INTERFACE_FLAGS "${ADD_HEADER_FLAGS}"
       TARGET_TYPE "${HDR_LIBRARY_TARGET_TYPE}"
       DEPS "${ADD_HEADER_DEPENDS}"
       FLAGS "${ADD_HEADER_FLAGS}"


        


More information about the libc-commits mailing list