[libc-commits] [PATCH] D127995: [libc] add printf pointer conv

[Michael Jones via Phabricator via libc-commits]

michaelrj marked an inline comment as done.
michaelrj added inline comments.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:361
+
+  written = __llvm_libc::sprintf(buff, "%p", buff);
+  EXPECT_GT(written, 0);
----------------
sivachandra wrote:
> Whats the point of this test?
I want to make sure it writes something for a real pointer, but since I don't know the value of the pointer before runtime I can't fix the return value. I use the other cases to check that it actually returns correct values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127995/new/

https://reviews.llvm.org/D127995