[libc-commits] [PATCH] D127920: [libc] Add a status page for math functions.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jun 16 09:06:51 PDT 2022


sivachandra added inline comments.


================
Comment at: libc/docs/math.rst:25
+  IEEE 754 standards.  By default, we will aim to be correctly rounded for all
+  rounding modes, based on the floating point environment:
+
----------------
I think you want to say, 

```
By default, we will aim to be correctly rounded for all rounding modes. The current rounding mode of the floating point environment is used to perform computations and produce the final result.
```

You probably don't need to list the different rounding modes below.


================
Comment at: libc/docs/math.rst:228
+* `The GNU C Library (glibc) <https://www.gnu.org/software/libc/>`_.
+* `The GNU MPFR Library <https://www.mpfr.org/>`_.
----------------
The MPFR or the GNU C library are not referenced in the text. Why list them here? Perhaps you want to add a section about testing and talk about MPFR there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127920/new/

https://reviews.llvm.org/D127920



More information about the libc-commits mailing list