[libc-commits] [PATCH] D126768: [libc][mem*] Introduce Sized/Backends for new mem framework

Clement Courbet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 15 06:30:55 PDT 2022


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/string/memory_utils/sized_op.h:137
+  // template <typename SrcAddrT1, typename SrcAddrT2>
+  // static inline int32_t threeWayCmp(SrcAddrT1 src1, SrcAddrT2 src2) {
+  //   const auto a = nativeLoad(src1);
----------------
?


================
Comment at: libc/test/src/string/memory_utils/backend_test.cpp:1
+
+#include "src/__support/CPP/Array.h"
----------------
Header ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126768/new/

https://reviews.llvm.org/D126768



More information about the libc-commits mailing list