[libc-commits] [PATCH] D127773: [libc] refactor printf file writing

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/stdio/printf_core/file_writer.h:24
+public:
+  FileWriter(::FILE *init_file) {
+    file = reinterpret_cast<__llvm_libc::File *>(init_file);
----------------
Something I realized while reviewing the other patch: why should this internal class take a `FILE*` arg only to cast to the internal file data structure?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127773/new/

https://reviews.llvm.org/D127773