[libc-commits] [PATCH] D127773: [libc] refactor printf file writing

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jun 14 12:06:57 PDT 2022


michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

Add return values to converter functions to allow for better error
handling when writing files. Also move the file writing code around to
be easier to read.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127773

Files:
  libc/src/stdio/CMakeLists.txt
  libc/src/stdio/fprintf.cpp
  libc/src/stdio/printf_core/CMakeLists.txt
  libc/src/stdio/printf_core/char_converter.h
  libc/src/stdio/printf_core/converter.cpp
  libc/src/stdio/printf_core/converter.h
  libc/src/stdio/printf_core/file_writer.cpp
  libc/src/stdio/printf_core/file_writer.h
  libc/src/stdio/printf_core/int_converter.h
  libc/src/stdio/printf_core/printf_main.cpp
  libc/src/stdio/printf_core/string_converter.h
  libc/src/stdio/printf_core/string_writer.cpp
  libc/src/stdio/printf_core/string_writer.h
  libc/src/stdio/printf_core/vfprintf_internal.cpp
  libc/src/stdio/printf_core/vfprintf_internal.h
  libc/src/stdio/printf_core/writer.cpp
  libc/src/stdio/printf_core/writer.h
  libc/test/src/stdio/fprintf_test.cpp
  libc/test/src/stdio/printf_core/converter_test.cpp
  libc/test/src/stdio/printf_core/string_writer_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127773.436878.patch
Type: text/x-patch
Size: 27505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220614/ab968d83/attachment-0001.bin>


More information about the libc-commits mailing list