[libc-commits] [PATCH] D127129: [libc] Fix cmake compatibility issue with list(POP_FRONT).

[Tue Ly via Phabricator via libc-commits]

lntue created this revision.
lntue added a reviewer: sivachandra.
Herald added subscribers: ecnelises, tschuett, mgorny.
Herald added projects: libc-project, All.
lntue requested review of this revision.

list(POP_FRONT) is only added to cmake in 3.15, while our base line
version is 3.13


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127129

Files:
  libc/cmake/modules/LLVMLibCLibraryRules.cmake
  libc/cmake/modules/LLVMLibCObjectRules.cmake
  libc/cmake/modules/LLVMLibCTestRules.cmake


Index: libc/cmake/modules/LLVMLibCTestRules.cmake
===================================================================
--- libc/cmake/modules/LLVMLibCTestRules.cmake
+++ libc/cmake/modules/LLVMLibCTestRules.cmake
@@ -212,7 +212,8 @@
     return()
   endif()
 
-  list(POP_FRONT flags flag)
+  list(GET flags 0 flag)
+  list(REMOVE_AT flags 0)
   extract_flag_modifier(${flag} real_flag modifier)
 
   if(NOT "${modifier}" STREQUAL "NO")
Index: libc/cmake/modules/LLVMLibCObjectRules.cmake
===================================================================
--- libc/cmake/modules/LLVMLibCObjectRules.cmake
+++ libc/cmake/modules/LLVMLibCObjectRules.cmake
@@ -126,7 +126,8 @@
     return()
   endif()
 
-  list(POP_FRONT flags flag)
+  list(GET flags 0 flag)
+  list(REMOVE_AT flags 0)
   extract_flag_modifier(${flag} real_flag modifier)
 
   if(NOT "${modifier}" STREQUAL "NO")
@@ -441,7 +442,8 @@
     return()
   endif()
 
-  list(POP_FRONT flags flag)
+  list(GET flags 0 flag)
+  list(REMOVE_AT flags 0)
   extract_flag_modifier(${flag} real_flag modifier)
 
   if(NOT "${modifier}" STREQUAL "NO")
Index: libc/cmake/modules/LLVMLibCLibraryRules.cmake
===================================================================
--- libc/cmake/modules/LLVMLibCLibraryRules.cmake
+++ libc/cmake/modules/LLVMLibCLibraryRules.cmake
@@ -207,7 +207,8 @@
     return()
   endif()
 
-  list(POP_FRONT flags flag)
+  list(GET flags 0 flag)
+  list(REMOVE_AT flags 0)
   extract_flag_modifier(${flag} real_flag modifier)
 
   if(NOT "${modifier}" STREQUAL "NO")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127129.434523.patch
Type: text/x-patch
Size: 1547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220606/aac35fdc/attachment.bin>