[libc-commits] [PATCH] D126830: [libc] move printf_main in to object library

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/stdio/printf_core/file_writer.h:20
 // function.
-void write_to_file(void *raw_pointer, const char *__restrict to_write,
+inline void write_to_file(void *raw_pointer, const char *__restrict to_write,
                    size_t len) {
----------------
Since we need pointers to these functions, they being inline is of no benefit? They could very well be in an object library of their own?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126830/new/

https://reviews.llvm.org/D126830