[libc-commits] [PATCH] D129920: [libc] Trivial implementation of std::optional

[Jeff Bailey via Phabricator via libc-commits]

jeffbailey updated this revision to Diff 448809.
jeffbailey added a comment.

Added two tests to test code review comment that noticed that an unset
optional would become set on assignment.  Then fixed the code for
that situation by factoring our storage into a consistent object.

Since the decision to use the C++ casing, changed Optional,
Nullopt and NulloptT to optional, nullopt, and nullopt_t for this
upload.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129920/new/

https://reviews.llvm.org/D129920

Files:
  libc/src/__support/CPP/CMakeLists.txt
  libc/src/__support/CPP/Optional.h
  libc/test/src/__support/CPP/CMakeLists.txt
  libc/test/src/__support/CPP/optional_test.cpp
  utils/bazel/llvm-project-overlay/libc/BUILD.bazel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129920.448809.patch
Type: text/x-patch
Size: 5918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220730/d1b8fef5/attachment.bin>