[libc-commits] [PATCH] D130727: [libc][NFC] Use STL case for type_traits

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jul 29 00:55:51 PDT 2022


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/__support/CPP/type_traits.h:48
+template <typename T> struct is_integral {
+  using TypeNoCV = remove_cv_t<T>;
+  static constexpr bool value =
----------------
Here and in `is_floating_point`, you have not updated `TypeNoCV`? May be do it for consistency, and because you are touching, make them private?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130727/new/

https://reviews.llvm.org/D130727



More information about the libc-commits mailing list