[libc-commits] [PATCH] D129278: [libc][math] Added sinhf function.

[Kirill Okhotnikov via Phabricator via libc-commits]

orex added inline comments.


================
Comment at: libc/src/math/generic/sinhf.cpp:60-62
+    double pe = fputil::polyeval(x2, 0.0, 0x1.5555555556583p-3,
+                                 0x1.111110d239f1fp-7, 0x1.a02b5a284013cp-13);
+    return fputil::multiply_add(xdbl, pe, xdbl);
----------------
lntue wrote:
> Will this change the accuracy / throughput / latency for this range of inputs?
> ```
> double x3 = x2 * xdbl;
> double pe = fputil::polyeval(x2, 0x1.5555555556583p-3, 0x1.111110d239f1fp-7, 0x1.a02b5a284013cp-13);
> return fputil::multiply_add(x3, pe, xdbl);
> ```
Performance:
  I've checked it with core-math, reducing the range to [-0.08, 0.08]. The performance was the same with ~5% precision.
Precision:
  The changes did not improve precision (the exceptional values still exceptional).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129278/new/

https://reviews.llvm.org/D129278