[libc-commits] [PATCH] D130662: [libc] Read and write errno via special getter and setter functions.

[Roland McGrath via Phabricator via libc-commits]

mcgrathr added inline comments.


================
Comment at: libc/src/errno/errno.cpp:15
+
+thread_local int __llvmlibc_test_errno = 0;
----------------
IMHO this doesn't really belong in the same directory as the "real" errno, let alone the same file.

I don't understand why these variables aren't inside `namespace __llvm_libc` like other internal symbols.



================
Comment at: libc/src/fcntl/linux/openat.cpp:13
 #include "src/__support/common.h"
+#include "src/errno/llvmlibc_errno.h"
 
----------------
I'm not at all clear on why this isn't in src/__support like other internal things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130662/new/

https://reviews.llvm.org/D130662