[libc-commits] [PATCH] D130584: [libc] Add Size Saving for String To Float

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In src/stdlib maybe, add a README.md which describes the new knob this patch is adding.



================
Comment at: libc/src/__support/str_to_float.h:81
 
+#ifndef LIBC_SIZE
+
----------------
Use a more specific flag name. Also, instead of excluding large blocks of code, move this to a separate header file and conditionally include it.


================
Comment at: libc/src/__support/str_to_float.h:592-613
   if (!truncated) {
     if (clinger_fast_path<T>(mantissa, exp10, outputMantissa, outputExp2)) {
       return;
     }
   }
 
   // Try Eisel-Lemire
----------------
Can this block be moved in to a function by itself and invoked conditionally?


================
Comment at: libc/test/src/__support/str_to_float_test.cpp:17
 public:
+#ifndef LIBC_SIZE
   template <class T>
----------------
Instead of conditional exclusion, move them to a more focused test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130584/new/

https://reviews.llvm.org/D130584