[libc-commits] [PATCH] D129215: [libc][math] Universal exp function for cosh/sinh calculation.

Kirill Okhotnikov via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 27 12:53:54 PDT 2022


orex added a subscriber: zimmermann6.
orex added inline comments.


================
Comment at: libc/test/src/math/expxf_test.cpp:36
+
+    EXPECT_MPFR_MATCH_DEFAULT(mpfr::Operation::Exp, x, fx(x), 0.5);
+  }
----------------
lntue wrote:
> Does it work for all rounding modes?
This is an universal function, therefore it can have some exception and ranges, which should be treated separately in each math function, which use that one. Paul (@zimmermann6) independently confirm, that derivative functions gives perfect result for all rounding modes. My tests form others reviews shows the same.

I put all rounding modes to avoid such question in the future.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129215/new/

https://reviews.llvm.org/D129215



More information about the libc-commits mailing list