[libc-commits] [PATCH] D129005: [libc][math] Improved performance of exp2f function.

[Tue Ly via Phabricator via libc-commits]

lntue added a comment.

Overall the improvement looks good for me.  Let's wait for @zimmermann6 to double check the numbers.



================
Comment at: libc/src/math/generic/CMakeLists.txt:504
     libc.src.__support.FPUtil.polyeval
     libc.include.math
   COMPILE_OPTIONS
----------------
missing `nearest_integer` dependency.


================
Comment at: libc/src/math/generic/exp2f.cpp:14
 #include "src/__support/FPUtil/PolyEval.h"
+#include "src/__support/FPUtil/nearest_integer.h"
 #include "src/__support/common.h"
----------------
You should also add `multiply_add` header and dependency directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129005/new/

https://reviews.llvm.org/D129005