[libc-commits] [PATCH] D130405: Implement TZ Variable Parsing Function.

[Thorsten via Phabricator via libc-commits]

tschuett added a comment.

Is there going to be fuzzer?



================
Comment at: libc/src/time/time_zone_posix.h:35
+public:
+  enum DateFormat : int { J, N, M };
+
----------------
enum class?


================
Comment at: libc/src/time/time_zone_posix.h:52
+
+    union {
+      NonLeapDay j;
----------------
Will this become the libc variant?


================
Comment at: libc/src/time/time_zone_posix.h:83
+  PosixTimeZone()
+      : m_spec(""), m_std_abbr("UTC"), m_std_offset(0), m_dst_abbr(""),
+        m_dst_offset(0) {}
----------------
This `m_` style is mostly used by LLDB. The rest of the code never uses it.

See https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130405/new/

https://reviews.llvm.org/D130405