[libc-commits] [PATCH] D130459: [libc] Add dirent.h functions opendir, readdir, closedir and dirfd.

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Jul 25 07:44:46 PDT 2022


lntue added inline comments.


================
Comment at: libc/src/__support/File/dir.h:50
+public:
+  // A directory is to be opened by the static mehtod open and closed
+  // by the close method. So, all constructors and destructor are declared
----------------
typo: *method*


================
Comment at: libc/src/__support/File/dir.h:61
+
+  struct dirent *read();
+
----------------
Is there ambiguity anywhere that `dirent` requires the `struct` keyword everywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130459/new/

https://reviews.llvm.org/D130459



More information about the libc-commits mailing list