[libc-commits] [PATCH] D130334: [libc] Add a simple StringStream class.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Jul 25 00:38:45 PDT 2022


sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: libc/src/__support/CPP/stringstream.h:26
+  size_t write_size = 0; // Size of already written data
+  size_t write_ptr = 0;  // The current write pointer
+  bool err = false;      // If an error occurs while writing
----------------
michaelrj wrote:
> why is this separate from write_size? It seems like they're tracking the same data.
Ah, I had a `seek` method which I removed as I don't need it anymore. Forgot to clean this up. Done now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130334/new/

https://reviews.llvm.org/D130334



More information about the libc-commits mailing list