[libc-commits] [PATCH] D130334: [libc] Add a simple StringStream class.
Michael Jones via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Jul 22 15:45:08 PDT 2022
michaelrj added inline comments.
================
Comment at: libc/src/__support/CPP/stringstream.h:15
+
+#include "src/__support/integer_to_string.h"
+
----------------
it would probably be better to include StringView explicitly instead of through integer_to_string.
================
Comment at: libc/src/__support/CPP/stringstream.h:26
+ size_t write_size = 0; // Size of already written data
+ size_t write_ptr = 0; // The current write pointer
+ bool err = false; // If an error occurs while writing
----------------
why is this separate from write_size? It seems like they're tracking the same data.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130334/new/
https://reviews.llvm.org/D130334
More information about the libc-commits
mailing list