[libc-commits] [PATCH] D130227: [libc] Add a convenience class and function for integer to string conversion.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/__support/integer_to_string_test.cpp:20
+TEST(LlvmLibcIntegerToStringTest, UINT8) {
+  EXPECT_TRUE(integer_to_string(uint8_t(0)).str().equals(StringView("0")));
+  EXPECT_TRUE(integer_to_string(uint8_t(1)).str().equals(StringView("1")));
----------------
michaelrj wrote:
> would it be better to implement an equality checker for string views?
Yes, I think we should. I will do it in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130227/new/

https://reviews.llvm.org/D130227