[libc-commits] [PATCH] D129920: [libc] Trivial implementation of std::optional

Jeff Bailey via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jul 19 22:31:47 PDT 2022


jeffbailey updated this revision to Diff 446046.
jeffbailey added a comment.

Updating with some review comments addressed, but not the asserts or the
testsuite, etc.  Posting this in case you want this committed to unblock
https://reviews.llvm.org/D129918 and the fix-ups to come in a subsequent
change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129920/new/

https://reviews.llvm.org/D129920

Files:
  libc/src/__support/CPP/CMakeLists.txt
  libc/src/__support/CPP/Optional.h
  libc/test/src/__support/CPP/CMakeLists.txt
  libc/test/src/__support/CPP/optional_test.cpp
  utils/bazel/llvm-project-overlay/libc/BUILD.bazel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129920.446046.patch
Type: text/x-patch
Size: 4344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220720/532ad8c1/attachment.bin>


More information about the libc-commits mailing list