[libc-commits] [PATCH] D129278: [libc][math] Added sinhf function.

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/test/src/math/sinhf_test.cpp:52
+      continue;
+    ASSERT_MPFR_MATCH(mpfr::Operation::Sinh, x, __llvm_libc::sinhf(x), 1.0);
+  }
----------------
0.5 for tolerance?


================
Comment at: libc/test/src/math/sinhf_test.cpp:60
+  float result = __llvm_libc::sinhf(x);
+  EXPECT_MPFR_MATCH(mpfr::Operation::Sinh, x, result, 1.0);
+  EXPECT_FP_EQ(x, result);
----------------
0.5 for tolerance?


================
Comment at: libc/test/src/math/sinhf_test.cpp:65
+  result = __llvm_libc::sinhf(x);
+  EXPECT_MPFR_MATCH(mpfr::Operation::Sinh, x, result, 1.0);
+  EXPECT_FP_EQ(x, result);
----------------
0.5 for tolerance?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129278/new/

https://reviews.llvm.org/D129278