[libc-commits] [PATCH] D130112: [libc] Add a method `find_last_of` to StringView.

[Jeff Bailey via Phabricator via libc-commits]

jeffbailey accepted this revision.
jeffbailey added a comment.
This revision is now accepted and ready to land.

Thanks!  One comment within.



================
Comment at: libc/test/src/__support/CPP/stringview_test.cpp:203
+
+TEST(LlvmLibcStringViewTest, FindLastOf) {
+  StringView Tmp("abada");
----------------
I apparently missed this in find_first_of, too, but it would be nice to have a test on an empty string to make sure that's handled correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130112/new/

https://reviews.llvm.org/D130112