[libc-commits] [PATCH] D129920: [libc] Trivial implementation of std::optional

[Jeff Bailey via Phabricator via libc-commits]

jeffbailey added a comment.

In D129920#3657405 <https://reviews.llvm.org/D129920#3657405>, @tschuett wrote:

> If the LLVM optional uses a union, then it is probably a good idea.
>
> I guess you are more interested in trivially copyable types.

It solves our current use, anyway. =)  I could add the && versions if folks think they'll get used soon (or that this will be confusing to not have them for now).  For this I was focused on what's needed for our case of implementing the TZ variable parsing (we use this for int, struct, and a string_view).

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129920/new/

https://reviews.llvm.org/D129920