[libc-commits] [PATCH] D129808: [libc] add unsafe mode to strlen

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jul 15 01:08:59 PDT 2022


sivachandra added inline comments.


================
Comment at: libc/src/string/CMakeLists.txt:11
     .memory_utils.memset_implementation
+  FLAGS
+    LLVM_LIBC_STRLEN_UNSAFE
----------------
I do not think this will do anything at all without a flag applier implemented somewhere. Also, can we consider a design without the FLAGS feature for comparison?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129808/new/

https://reviews.llvm.org/D129808



More information about the libc-commits mailing list