[libc-commits] [PATCH] D129543: [libc] Linux threads - Setup TLS area of a new thread and cleanup at exit.

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

overall LGTM, with a few stylish nits



================
Comment at: libc/config/linux/app.h:18
 
 // Data structure to capture properties of the linux/ELF TLS.
+struct TLSImage {
----------------
Nit: If you're adjusting the comment below to talk about a TLS image instead of just a TLS, you should do it here too.


================
Comment at: libc/src/__support/threads/linux/thread.cpp:113
   auto *start_args = reinterpret_cast<StartArgs *>(get_start_args_addr());
   auto *attrib = start_args->thread_attrib;
+
----------------
Nit: delete this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129543/new/

https://reviews.llvm.org/D129543