[libc-commits] [PATCH] D129275: [libc][math] Added coshf function.

Tue Jul 12 06:37:46 PDT 2022

zimmermann6 added a comment.

In D129275#3645137 <https://reviews.llvm.org/D129275#3645137>, @orex wrote:

> Can you try to put all the chain on top of the revision 60d6be5dd3f411cfe1b5392cbb <https://reviews.llvm.org/rG60d6be5dd3f411cfe1b5392cbbd6131d0ade2faa>... for now. I'll rebase the revisions to the last main tonight.

thank you, it works perfectly. All exhaustive tests do pass for the 4 rounding modes. For the efficiency I get on a AMD EPYC 7282 with gcc 10.2.1 and clang 11.0.1-2:

  zimmerma at biscotte:~/svn/core-math$ LIBM=/localdisk/zimmerma/llvm-project/build/projects/libc/lib/libllvmlibc.a CORE_MATH_LAUNCHER="/localdisk/zimmerma/glibc-2.35/install/lib/ld-linux-x86-64.so.2 --library-path /localdisk/zimmerma/glibc-2.35/install/lib" CORE_MATH_PERF_MODE=rdtsc ./perf.sh coshf
  GNU libc version: 2.35
  GNU libc release: stable
  17.537
  15.789
  35.447

which means 18 cycles for CORE-MATH, 16 cycles for glibc 2.35, and 35 for llvm-libc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129275/new/

https://reviews.llvm.org/D129275