[libc-commits] [PATCH] D129388: [libc] add dependencies to generic sqrt tests
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Jul 8 16:26:30 PDT 2022
sivachandra added a comment.
IMHO, this is not correct - you are introducing an artificial dependency and your expectation will break in future when sqrt functions are actually available say via inline assembly. You should rather just disable these tests for targets they are not ready for.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129388/new/
https://reviews.llvm.org/D129388
More information about the libc-commits
mailing list