[libc-commits] [PATCH] D129248: [libc] Make div test names unique

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jul 7 08:08:59 PDT 2022


abrachet marked an inline comment as done.
abrachet added inline comments.


================
Comment at: libc/test/src/stdlib/DivTest.h:39
   using LlvmLibcDivTest = DivTest<IntType, ReturnType>;                        \
-  TEST_F(LlvmLibcDivTest, SimpleTest) { simpleTest(func); }
+  TEST_F(LlvmLibcDivTest, CAT(SimpleTest, ReturnType)) { simpleTest(func); }
----------------
sivachandra wrote:
> Can `CAT` be inlined?
Ah you're right. For some reason I thought there would be some issue with not forcing this to be evaluated first. I have committed it with just `SimpleTest##ReturnType`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129248/new/

https://reviews.llvm.org/D129248



More information about the libc-commits mailing list