[libc-commits] [PATCH] D114236: [libc] Fix 64-bit ARM support and header includes

[Dominic Chen via Phabricator via libc-commits]

ddcc updated this revision to Diff 403909.
ddcc added a comment.

Add apple reference


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114236/new/

https://reviews.llvm.org/D114236

Files:
  libc/src/__support/FPUtil/PlatformDefs.h
  libc/test/src/math/exhaustive/cosf_test.cpp
  libc/test/src/math/exhaustive/expm1f_test.cpp
  libc/test/src/math/exhaustive/sinf_test.cpp
  libc/test/src/math/exhaustive/sqrtf_test.cpp


Index: libc/test/src/math/exhaustive/sqrtf_test.cpp
===================================================================
--- libc/test/src/math/exhaustive/sqrtf_test.cpp
+++ libc/test/src/math/exhaustive/sqrtf_test.cpp
@@ -7,7 +7,6 @@
 //===---------------------------------------------------------------------===//
 
 #include "src/__support/FPUtil/FPBits.h"
-#include "src/__support/FPUtil/TestHelpers.h"
 #include "src/math/sqrtf.h"
 #include "utils/MPFRWrapper/MPFRUtils.h"
 #include <math.h>
Index: libc/test/src/math/exhaustive/sinf_test.cpp
===================================================================
--- libc/test/src/math/exhaustive/sinf_test.cpp
+++ libc/test/src/math/exhaustive/sinf_test.cpp
@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/__support/FPUtil/FPBits.h"
-#include "src/__support/FPUtil/TestHelpers.h"
 #include "src/math/sinf.h"
 #include "utils/MPFRWrapper/MPFRUtils.h"
 #include <math.h>
Index: libc/test/src/math/exhaustive/expm1f_test.cpp
===================================================================
--- libc/test/src/math/exhaustive/expm1f_test.cpp
+++ libc/test/src/math/exhaustive/expm1f_test.cpp
@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/__support/FPUtil/FPBits.h"
-#include "src/__support/FPUtil/TestHelpers.h"
 #include "src/math/expm1f.h"
 #include "utils/MPFRWrapper/MPFRUtils.h"
 #include <math.h>
Index: libc/test/src/math/exhaustive/cosf_test.cpp
===================================================================
--- libc/test/src/math/exhaustive/cosf_test.cpp
+++ libc/test/src/math/exhaustive/cosf_test.cpp
@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/__support/FPUtil/FPBits.h"
-#include "src/__support/FPUtil/TestHelpers.h"
 #include "src/math/cosf.h"
 #include "utils/MPFRWrapper/MPFRUtils.h"
 #include <math.h>
Index: libc/src/__support/FPUtil/PlatformDefs.h
===================================================================
--- libc/src/__support/FPUtil/PlatformDefs.h
+++ libc/src/__support/FPUtil/PlatformDefs.h
@@ -15,7 +15,8 @@
 #define X87_FPU
 #endif
 
-#if defined(_WIN32)
+// https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms
+#if defined(_WIN32) || (defined(__APPLE__) && defined(__aarch64__))
 #define LONG_DOUBLE_IS_DOUBLE
 #endif
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114236.403909.patch
Type: text/x-patch
Size: 2456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220128/307b5f8b/attachment-0001.bin>