[libc-commits] [PATCH] D118396: [libc] Add POSIX close, fsync, open, read and write functions.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/include/llvm-libc-macros/linux/fcntl-macros.h:1
+//===-- Definition of macros from fcntl.h ---------------------------------===//
+//
----------------
abrachet wrote:
> With errno we just include `linux/errno.h` can we use `linux/fcntl.h`?
I think, including linux headers was an error on our part. Primary reason is that the linux headers bring in more names and pollute the user namespace. I think there are ways to avoid this hard-coding as done in this patch, but I will propose that in a follow up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118396/new/

https://reviews.llvm.org/D118396