[libc-commits] [PATCH] D118173: [libc] Refactor sqrt implementations and add tests for generic sqrt implementations.

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

mostly LGTM, with a few nits.



================
Comment at: libc/src/__support/FPUtil/CMakeLists.txt:36
+add_subdirectory(generic)
\ No newline at end of file

----------------
fix


================
Comment at: libc/src/__support/FPUtil/generic/CMakeLists.txt:7
+)
\ No newline at end of file

----------------
fix


================
Comment at: libc/src/__support/FPUtil/generic/sqrt.h:115
+    return x86::sqrt(x);
+  } else {
+    // IEEE floating points formats.
----------------
this else is unnecessary, since the only other branch returns. In addition, the other branch doesn't need braces, since it only has one line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118173/new/

https://reviews.llvm.org/D118173