[libc-commits] [PATCH] D117979: [libc][cmake] Make `add_tablegen` calls match others

John Ericson via Phabricator via libc-commits libc-commits at lists.llvm.org
Sat Jan 22 22:28:38 PST 2022


Ericson2314 created this revision.
Ericson2314 added reviewers: phosek, compnerd, beanz.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added a project: libc-project.
Ericson2314 requested review of this revision.

in all the other `add_tablegen` calls, the project name is so transformed so it
can be a prefix of a CMake variable. I think it is better to do do that here
too for consistency.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117979

Files:
  libc/utils/HdrGen/PrototypeTestGen/CMakeLists.txt
  libc/utils/tools/WrapperGen/CMakeLists.txt


Index: libc/utils/tools/WrapperGen/CMakeLists.txt
===================================================================
--- libc/utils/tools/WrapperGen/CMakeLists.txt
+++ libc/utils/tools/WrapperGen/CMakeLists.txt
@@ -1,6 +1,6 @@
 set(LLVM_LINK_COMPONENTS Support)
 
-add_tablegen(libc-wrappergen llvm-libc
+add_tablegen(libc-wrappergen LLVM_LIBC
   Main.cpp
 )
 
Index: libc/utils/HdrGen/PrototypeTestGen/CMakeLists.txt
===================================================================
--- libc/utils/HdrGen/PrototypeTestGen/CMakeLists.txt
+++ libc/utils/HdrGen/PrototypeTestGen/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_tablegen(libc-prototype-testgen llvm-libc
+add_tablegen(libc-prototype-testgen LLVM_LIBC
   PrototypeTestGen.cpp
 )
 target_link_libraries(libc-prototype-testgen PRIVATE LibcTableGenUtil)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117979.402294.patch
Type: text/x-patch
Size: 804 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220123/299a7259/attachment.bin>


More information about the libc-commits mailing list