[libc-commits] [PATCH] D117838: [libc] Move the remaining public types to their own type headers.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/include/llvm-libc-types/tm.h:9
+
+#ifndef __LLVM_LIBC_TYPES_TM_H__
+#define __LLVM_LIBC_TYPES_TM_H__
----------------
michaelrj wrote:
> is there a reason behind the trailing underscores? It doesn't match the format of the other header guards.
We need the prefix as we cannot pollute the namespace. But, the trailing underscores are just my personal choice. We can remove if there is a reason we should not have them.

The normal header guard rule does not apply here (and is not good enough because of namespace pollution) as these are part of the public headers and not internal libc headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117838/new/

https://reviews.llvm.org/D117838