[libc-commits] [PATCH] D117258: [WIP][libc] add core parsing for printf

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/stdio/printf_conv_core.h:25
+  size_t cur_pos = 0;
+  enum BuffType { string, file } buff_type;
+
----------------
Use enum class.


================
Comment at: libc/src/stdio/printf_conv_core.h:64
+
+  size_t get_bytes_written() { return cur_pos; }
+
----------------
Mark this method const.


================
Comment at: libc/src/stdio/printf_conv_core.h:73
+
+enum LengthModifier { hh, h, l, ll, j, z, t, L, none };
+
----------------
Use enum class.


================
Comment at: libc/src/stdio/printf_impl.h:1
+//===-- Internal definition of printf ---------------------------*- C++ -*-===//
+//
----------------
Why are these functions implemented in the header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117258/new/

https://reviews.llvm.org/D117258