[libc-commits] [libc] ba6a397 - [libc] add working ARM entrypoints

[Michael Jones via libc-commits]

Author: Michael Jones
Date: 2022-01-12T14:24:18-08:00
New Revision: ba6a3972d74c0a7fbdece83378f9834d56106d94

URL: https://github.com/llvm/llvm-project/commit/ba6a3972d74c0a7fbdece83378f9834d56106d94
DIFF: https://github.com/llvm/llvm-project/commit/ba6a3972d74c0a7fbdece83378f9834d56106d94.diff

LOG: [libc] add working ARM entrypoints

Some functions were added to x86_64 that were untested on Aarch64. Now
that I've had an opportunity to test them, they all work on Aarch64 with
the minor formatting change included.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D117146

Added: 
    

Modified: 
    libc/config/linux/aarch64/entrypoints.txt
    libc/test/src/stdlib/strtold_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 7b9027efa3360..4a3e287f14d3c 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -23,18 +23,23 @@ set(TARGET_LIBC_ENTRYPOINTS
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bzero
+    libc.src.string.memccpy
     libc.src.string.memchr
     libc.src.string.memcmp
     libc.src.string.memcpy
     libc.src.string.memmove
-    libc.src.string.memset
+    libc.src.string.mempcpy
     libc.src.string.memrchr
+    libc.src.string.memset
+    libc.src.string.stpcpy
+    libc.src.string.stpncpy
     libc.src.string.strcat
     libc.src.string.strchr
-    libc.src.string.strcpy
     libc.src.string.strcmp
+    libc.src.string.strcpy
     libc.src.string.strcspn
     libc.src.string.strlen
+    libc.src.string.strncat
     libc.src.string.strncmp
     libc.src.string.strncpy
     libc.src.string.strnlen
@@ -53,6 +58,7 @@ set(TARGET_LIBC_ENTRYPOINTS
     # stdlib.h entrypoints
     libc.src.stdlib.abs
     libc.src.stdlib.atoi
+    libc.src.stdlib.atof
     libc.src.stdlib.atol
     libc.src.stdlib.atoll
     libc.src.stdlib.bsearch
@@ -62,7 +68,10 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.stdlib.llabs
     libc.src.stdlib.lldiv
     libc.src.stdlib.qsort
+    libc.src.stdlib.strtod
+    libc.src.stdlib.strtof
     libc.src.stdlib.strtol
+    libc.src.stdlib.strtold
     libc.src.stdlib.strtoll
     libc.src.stdlib.strtoul
     libc.src.stdlib.strtoull

diff  --git a/libc/test/src/stdlib/strtold_test.cpp b/libc/test/src/stdlib/strtold_test.cpp
index 0aa8f45e623d2..c5835f9cd1db2 100644
--- a/libc/test/src/stdlib/strtold_test.cpp
+++ b/libc/test/src/stdlib/strtold_test.cpp
@@ -64,7 +64,7 @@ class LlvmLibcStrToLDTest : public __llvm_libc::testing::Test {
     char *str_end = nullptr;
 
 #if defined(LONG_DOUBLE_IS_DOUBLE)
-    __llvm_libc::fputil::FPBits<long double> expectedFP =
+    __llvm_libc::fputil::FPBits<long double> expected_fp =
         __llvm_libc::fputil::FPBits<long double>(expectedRawData64);
     const int expectedErrno = expectedErrno64;
 #elif defined(SPECIAL_X86_LONG_DOUBLE)
@@ -72,7 +72,7 @@ class LlvmLibcStrToLDTest : public __llvm_libc::testing::Test {
         __llvm_libc::fputil::FPBits<long double>(expectedRawData80);
     const int expected_errno = expectedErrno80;
 #else
-    __llvm_libc::fputil::FPBits<long double> expectedFP =
+    __llvm_libc::fputil::FPBits<long double> expected_fp =
         __llvm_libc::fputil::FPBits<long double>(expectedRawData128);
     const int expectedErrno = expectedErrno128;
 #endif