[libc-commits] [PATCH] D117146: [libc] add working ARM entrypoints

[Michael Jones via Phabricator via libc-commits]

michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue, abrachet.
Herald added subscribers: libc-commits, ecnelises, tschuett, pengfei, kristof.beyls.
Herald added a project: libc-project.
michaelrj requested review of this revision.

Some functions were added to x86_64 that were untested on Aarch64. Now
that I've had an opportunity to test them, they all work on Aarch64 with
the minor formatting change included.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117146

Files:
  libc/config/linux/aarch64/entrypoints.txt
  libc/test/src/stdlib/strtold_test.cpp


Index: libc/test/src/stdlib/strtold_test.cpp
===================================================================
--- libc/test/src/stdlib/strtold_test.cpp
+++ libc/test/src/stdlib/strtold_test.cpp
@@ -64,7 +64,7 @@
     char *str_end = nullptr;
 
 #if defined(LONG_DOUBLE_IS_DOUBLE)
-    __llvm_libc::fputil::FPBits<long double> expectedFP =
+    __llvm_libc::fputil::FPBits<long double> expected_fp =
         __llvm_libc::fputil::FPBits<long double>(expectedRawData64);
     const int expectedErrno = expectedErrno64;
 #elif defined(SPECIAL_X86_LONG_DOUBLE)
@@ -72,7 +72,7 @@
         __llvm_libc::fputil::FPBits<long double>(expectedRawData80);
     const int expected_errno = expectedErrno80;
 #else
-    __llvm_libc::fputil::FPBits<long double> expectedFP =
+    __llvm_libc::fputil::FPBits<long double> expected_fp =
         __llvm_libc::fputil::FPBits<long double>(expectedRawData128);
     const int expectedErrno = expectedErrno128;
 #endif
Index: libc/config/linux/aarch64/entrypoints.txt
===================================================================
--- libc/config/linux/aarch64/entrypoints.txt
+++ libc/config/linux/aarch64/entrypoints.txt
@@ -23,18 +23,23 @@
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bzero
+    libc.src.string.memccpy
     libc.src.string.memchr
     libc.src.string.memcmp
     libc.src.string.memcpy
     libc.src.string.memmove
-    libc.src.string.memset
+    libc.src.string.mempcpy
     libc.src.string.memrchr
+    libc.src.string.memset
+    libc.src.string.stpcpy
+    libc.src.string.stpncpy
     libc.src.string.strcat
     libc.src.string.strchr
-    libc.src.string.strcpy
     libc.src.string.strcmp
+    libc.src.string.strcpy
     libc.src.string.strcspn
     libc.src.string.strlen
+    libc.src.string.strncat
     libc.src.string.strncmp
     libc.src.string.strncpy
     libc.src.string.strnlen
@@ -53,6 +58,7 @@
     # stdlib.h entrypoints
     libc.src.stdlib.abs
     libc.src.stdlib.atoi
+    libc.src.stdlib.atof
     libc.src.stdlib.atol
     libc.src.stdlib.atoll
     libc.src.stdlib.bsearch
@@ -62,7 +68,10 @@
     libc.src.stdlib.llabs
     libc.src.stdlib.lldiv
     libc.src.stdlib.qsort
+    libc.src.stdlib.strtod
+    libc.src.stdlib.strtof
     libc.src.stdlib.strtol
+    libc.src.stdlib.strtold
     libc.src.stdlib.strtoll
     libc.src.stdlib.strtoul
     libc.src.stdlib.strtoull


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117146.399437.patch
Type: text/x-patch
Size: 2393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220112/2c413c17/attachment.bin>