[libc-commits] [PATCH] D119789: [libc] change ASAN condition to generator expression

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/stdlib/CMakeLists.txt:206
+
+  if($<TARGET_EXISTS:RTGwpAsan.${LIBC_TARGET_ARCHITECTURE}>)
     list(APPEND SCUDO_DEPS RTGwpAsan.${LIBC_TARGET_ARCHITECTURE} 
----------------
Using it in an `if` block does not seem to change the semantics. However, the following works for me:

```
 list(APPEND SCUDO_DEPS $<$<TARGET_EXISTS:RTGwpAsan.${LIBC_TARGET_ARCHITECTURE}>:RTGwpAsan.${LIBC_TARGET_ARCHITECTURE}>
                        $<$<TARGET_EXISTS:RTGwpAsanBacktraceLibc.${LIBC_TARGET_ARCHITECTURE}>:RTGwpAsanBacktraceLibc.${LIBC_TARGET_ARCHITECTURE}>
                        $<$<TARGET_EXISTS:RTGwpAsanSegvHandler.${LIBC_TARGET_ARCHITECTURE}>:RTGwpAsanSegvHandler.${LIBC_TARGET_ARCHITECTURE}>)

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119789/new/

https://reviews.llvm.org/D119789