[libc-commits] [PATCH] D119403: Introduce getenv to LLVM libc

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/loader/linux/x86_64/start.cpp:32
 
 // TODO: Declare var an extern var in config/linux/app.h so that other
 // libc functions can make use of the application wide information. For
----------------
Nit: Now that you have declared `app` as an extern, we can remove this TODO.


================
Comment at: libc/src/stdlib/getenv.cpp:32
+
+    // Check for PATH=, vs PATH1=, PATH2=, etc...
+    if (cur[env_var_name.size()] != '=')
----------------
Nit: I didn't understand this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119403/new/

https://reviews.llvm.org/D119403