[libc-commits] [PATCH] D118962: [libc] Implement log1pf correctly rounded to all rounding modes.

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

overall LGTM with minor nit



================
Comment at: libc/src/math/generic/log1pf.cpp:33
+// Lookup table for log(f) = log(1 + n*2^(-7)) where n = 0..127.
+static constexpr double LOG_F[128] = {
+    0x0.0000000000000p+0, 0x1.fe02a6b106788p-8, 0x1.fc0a8b0fc03e3p-7,
----------------
should this be in `common_constants.cpp`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118962/new/

https://reviews.llvm.org/D118962