[libc-commits] [PATCH] D118889: [libc] Disable rtti/expections

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/cmake/modules/LLVMLibCObjectRules.cmake:16
+    list(APPEND compile_options "/GR-")
+  elseif(CMAKE_CXX_COMPILER_ID MATCHES "XL")
+    list(APPEND compile_options "-qnoeh")
----------------
gchatelet wrote:
> This is cloned from LLVM' [[  https://github.com/llvm/llvm-project/blob/36c36c1ee3b01b2d4a9e7ee12c9c23a98659e0fb/llvm/cmake/modules/AddLLVM.cmake#L7 | llvm_update_compile_flags ]] but I'm not sure we want to support IBM's compiler at this point.
> 
Up to you. We don't have any testing planned in the near future so it will be just bit rot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118889/new/

https://reviews.llvm.org/D118889