[libc-commits] [PATCH] D114637: [libc] Optimized version of memmove

[Andre Vieira via Phabricator via libc-commits]

avieira added a comment.

In D114637#3300668 <https://reviews.llvm.org/D114637#3300668>, @gchatelet wrote:

> @avieira Shall I transform
>
>   static void move(char *dst, const char *src) {
>     const auto value = Element::load(src);
>     Repeated<Element, ElementCount - 1>::move(dst + Element::SIZE, src + Element::SIZE);
>     Element::store(dst, value);
>   }
>
> into
>
>   static void move(char *dst, const char *src) {
>     const auto value = load(src);
>     store(dst, value);
>   }
>
> before submitting?
> As discussed offline, this seems to help on aarch64 but doesn't seem to affect x86.

Yes please!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114637/new/

https://reviews.llvm.org/D114637