[libc-commits] [PATCH] D118962: [libc] Implement log1pf correctly rounded to all rounding modes.

[Tue Ly via Phabricator via libc-commits]

lntue added a comment.

In D118962#3296015 <https://reviews.llvm.org/D118962#3296015>, @zimmermann6 wrote:

> I get several warnings when I compile this version:
>
>   In file included from /localdisk/zimmerma/llvm-project/libc/src/stdlib/strtold.cpp:11:
>   In file included from /localdisk/zimmerma/llvm-project/libc/src/__support/str_to_float.h:16:
>   /localdisk/zimmerma/llvm-project/libc/src/__support/high_precision_decimal.h:115:42: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'uint32_t' (aka 'unsigned int') [-Wsign-compare]
>       if (roundToDigit < 0 || roundToDigit >= this->num_digits) {
>                               ~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~
>   /localdisk/zimmerma/llvm-project/libc/src/__support/high_precision_decimal.h:121:26: warning: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Wsign-compare]
>           roundToDigit + 1 == this->num_digits) {
>           ~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~

We are in the process of cleaning up the project to build with gcc.  Thess warnings will be fixed soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118962/new/

https://reviews.llvm.org/D118962