[libc-commits] [PATCH] D118791: [libc][Obvious] Fix a mismatch signature of HighPrecisionDecimal::should_round_up.

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Feb 3 14:31:42 PST 2022


michaelrj added a comment.

My reason is that `roundToDigit` can be negative, and changing it to be unsigned would break that. The only line where `should_round_up` is called is line 367, and it's passed `decimal_point`, which is a signed integer which may sometimes be negative.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118791/new/

https://reviews.llvm.org/D118791



More information about the libc-commits mailing list