[libc-commits] [libc] d065472 - Revert "[libc][NFC] Add -fno-lax-vector-conversions compilation flag"

Guillaume Chatelet via libc-commits libc-commits at lists.llvm.org
Tue Dec 27 00:30:55 PST 2022


Author: Guillaume Chatelet
Date: 2022-12-27T08:30:19Z
New Revision: d065472c9ebca5efea7361c229ead7d5cb6f81b5

URL: https://github.com/llvm/llvm-project/commit/d065472c9ebca5efea7361c229ead7d5cb6f81b5
DIFF: https://github.com/llvm/llvm-project/commit/d065472c9ebca5efea7361c229ead7d5cb6f81b5.diff

LOG: Revert "[libc][NFC] Add -fno-lax-vector-conversions compilation flag"

This breaks aarch64 build.

This reverts commit 32f4c3f1033e32b7d2b7ba310c46c8c0d4013eb0.

Added: 
    

Modified: 
    libc/cmake/modules/LLVMLibCObjectRules.cmake
    utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/LLVMLibCObjectRules.cmake b/libc/cmake/modules/LLVMLibCObjectRules.cmake
index 35c016df63654..3502bcf022fa4 100644
--- a/libc/cmake/modules/LLVMLibCObjectRules.cmake
+++ b/libc/cmake/modules/LLVMLibCObjectRules.cmake
@@ -23,7 +23,6 @@ function(_get_common_compile_options output_var flags)
     list(APPEND compile_options "-ffreestanding")
     list(APPEND compile_options "-fno-builtin")
     list(APPEND compile_options "-fno-exceptions")
-    list(APPEND compile_options "-fno-lax-vector-conversions")
     list(APPEND compile_options "-fno-unwind-tables")
     list(APPEND compile_options "-fno-asynchronous-unwind-tables")
     list(APPEND compile_options "-fno-rtti")

diff  --git a/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl b/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
index 7b5e9a1a4c6dd..6a4c1a56d27f7 100644
--- a/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
+++ b/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
@@ -69,7 +69,6 @@ def libc_function(
     copts = copts or []
     copts.append("-O3")
     copts.append("-fno-builtin")
-    copts.append("-fno-lax-vector-conversions")
 
     # We compile the code twice, the first target is suffixed with ".__internal__" and contains the
     # C++ functions in the "__llvm_libc" namespace. This allows us to test the function in the


        


More information about the libc-commits mailing list