[libc-commits] [PATCH] D140526: [libc] Handle allocation failures gracefully in FILE related API.

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Dec 22 10:09:12 PST 2022


michaelrj accepted this revision.
michaelrj added a comment.

LGTM with one nit



================
Comment at: libc/src/__support/File/linux_file.cpp:146
     return Error(-fd);
     // return {nullptr, -fd};
   }
----------------
could you delete this comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140526/new/

https://reviews.llvm.org/D140526



More information about the libc-commits mailing list